refac(internal/github): single graphql query to fetch all SSH keys at once - #723
Merged
Conversation
OliverTrautvetter
requested changes
Aug 21, 2026
OliverTrautvetter
left a comment
OliverTrautvetter
left a comment
Member
There was a problem hiding this comment.
Looks good in general, some small stuff
gnarlex
force-pushed
the
bootstrap-ssh-graphql
branch
from
August 21, 2026 15:15
c159061 to
6d58245
Compare
gnarlex
force-pushed
the
bootstrap-ssh-graphql
branch
2 times, most recently
from
August 25, 2026 08:56
8c18468 to
5cd5d82
Compare
… once Signed-off-by: Alex Klein <alex@codesphere.com>
gnarlex
force-pushed
the
bootstrap-ssh-graphql
branch
from
August 26, 2026 12:12
5cd5d82 to
a653d89
Compare
Signed-off-by: gnarlex <24435169+gnarlex@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We are making 1 list request to get all members of a team, and 1 get request for each member's ssh key. For large team's, this results in a lot of requests being made, which may quickly contribute to hitting GitHub API rate limits,
Make a single GraphQL query to get all keys at once.